Support placement type for disks #3555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharsonia
force-pushed
the
SupportPlacementTypeForDisks
branch
7 times, most recently
from
c9f8370 to
bf0c1bf
Compare
squirrelsc
reviewed
Dec 13, 2024
sharsonia
force-pushed
the
SupportPlacementTypeForDisks
branch
5 times, most recently
from
245208c to
a23371e
Compare
How is the placement type used for? If it's set in runbook only, it doesn't need to be in the feature level. |
squirrelsc
reviewed
Dec 13, 2024
squirrelsc
reviewed
Dec 13, 2024
squirrelsc
reviewed
Dec 13, 2024
squirrelsc
reviewed
Dec 13, 2024
squirrelsc
reviewed
Dec 13, 2024
squirrelsc
reviewed
Dec 13, 2024
sharsonia
force-pushed
the
SupportPlacementTypeForDisks
branch
6 times, most recently
from
c11802f to
084292f
Compare
sharsonia
force-pushed
the
SupportPlacementTypeForDisks
branch
from
084292f to
92ec624
Compare
sharsonia
force-pushed
the
SupportPlacementTypeForDisks
branch
15 times, most recently
from
6bb7f1c to
1ef5d37
Compare
sharsonia
force-pushed
the
SupportPlacementTypeForDisks
branch
2 times, most recently
from
e1fafb9 to
26031f8
Compare
|
@LiliDeng LGTM |
sharsonia
force-pushed
the
SupportPlacementTypeForDisks
branch
3 times, most recently
from
6883ee6 to
84aacb6
Compare
sharsonia
force-pushed
the
SupportPlacementTypeForDisks
branch
3 times, most recently
from
a1429a4 to
bf42346
Compare
sharsonia
force-pushed
the
SupportPlacementTypeForDisks
branch
from
bf42346 to
3e8cc1d
Compare
LiliDeng
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Ephemeral OS Disk placement value is hardcoded in LISA. This PR enables LISA to fetch the Ephemeral OS disk placement type value from the SKU capability in Azure VMs.
To allow this, DiskPlacementType setting and supported values are added to the AzureDiskOptionSettings.
LISA user can also pass the EphemeralDiskPlacementType from Runbook to deploy VM with specific supported placement type value.
For Ephemeral OS Disk placement types available, refer
https://learn.microsoft.com/en-us/azure/virtual-machines/ephemeral-os-disks-faq